MoveToContainerDialog verifyAuditEvents to use Runnable to wait for next transactionId before doing audit diff checks #2606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
reviewed
Aug 6, 2025
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
Am I remembering correctly that the error was happening when no rows are returned?
Consider waiting for an event to occur. Ignoring the exception here will likely just cause a different failure down the line.
Contributor
Author
The error was when the code was getting events from the previous transaction instead of what should have been the new audit events from the move action. I updated this code being referenced to throw the exception instead of just returning null. |
labkey-tchad
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
See related PR for rationale.
Related Pull Requests
Changes